Partially restore URI.escape behaviour to avoid breaking change #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Landreas thanks. The breaking change was unintented. I will merge this PR, release 5.5.2 and yank 5.5.1 |
tagliala
added a commit
that referenced
this pull request
Dec 27, 2017
* hotfix/5.5.2: Update version and changelog Update gem before install Revert "Fix RuboCop false positive" Update RuboCop dependency Test against latest Ruby versions Fix RuboCop false positive Update development dependencies Partially restore URI.escape behaviour to avoid breaking change (#179)
|
5.5.1 yanked Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First: Thanks for maintaining this gem!
After updating to the lastest version i've noticed a breaking change regarding handling of slashes in translation files. Some investigation showed that the commit dc77562 changed the behaviour how the translated paths are escaped.
While avoiding
URI.escapeis desirable, such a big change in the way translated paths are handled should maybe happen in a major gem update?I'm open to different solutions and i've started to avoid slashes in translation files, but maybe we should restore the old behaviour for now and change this in a bigger update?