You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
URI.escape and CGI.escape are a bit different https://stackoverflow.com/questions/2824126/whats-the-difference-between-uri-escape-and-cgi-escape#answer-13059657 and using gsub on CGI.escape should be avoided IMO since one of the reasons URI.escape was marked as obsolete is because it's just a simple gsub so I would like to propose restoring URI.escape behavior by using addressable gem -- reason: as mentioned hereThe closest to the URI spec seems to be the Addressable gem -- it will restore the URI.escape behavior while keeping the code free from any offenses
Hello 馃憢
Thank you for maintaining this gem!!
I want to raise another issue similar to #179
After updating to the latest version there was another breaking change when handling spaces in translation files
URI.escape
andCGI.escape
are a bit different https://stackoverflow.com/questions/2824126/whats-the-difference-between-uri-escape-and-cgi-escape#answer-13059657 and usinggsub
onCGI.escape
should be avoided IMO since one of the reasonsURI.escape
was marked as obsolete is because it's just a simplegsub
so I would like to propose restoringURI.escape
behavior by using addressable gem -- reason: as mentioned hereThe closest to the URI spec seems to be the Addressable gem
-- it will restore theURI.escape
behavior while keeping the code free from any offensesI made a PR to illustrate this change: #180
The text was updated successfully, but these errors were encountered: