Document (new) exec & filesystem tools#1768
Document (new) exec & filesystem tools#1768vorburger wants to merge 4 commits intoenola-dev:mainfrom
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the clarity and usability of Enola's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request documents the newly introduced exec and built-in filesystem tools, and refactors the tool registration logic for better maintainability. The changes are well-structured. My review includes a critical recommendation to add a security warning for the exec tool in the documentation and a minor correction to an instruction in a test agent file to improve clarity and correctness.
| ``` | ||
|
|
||
| ## Exec | ||
| ## Exec ▶️ |
There was a problem hiding this comment.
The exec tool is very powerful as it can run any shell command. This introduces a significant security risk, as a compromised or manipulated prompt could lead to arbitrary code execution on the machine running Enola. It's crucial to add a prominent security warning to this documentation, similar to the cautions for other powerful tools.
For example:
> [!CAUTION]
> The `exec` tool can execute arbitrary shell commands. This is a powerful capability that introduces significant security risks. Only enable this tool in trusted environments.There was a problem hiding this comment.
That's a great point, Thank You for pointing this out Gemini Code Assist. I've added warnings to the doc now.
@temi-ro FYI
|
This is now merged as part of #1770. |
Relates to #1644 and #1762 for #1631.
Includes #1767, just to avoid
rebaseconflicts.@temi-ro PTAL - OK for you?