clean: Avoid repetition in FileSystemTools set-up

[vorburger]

Relates to #1762.

@temi-ro plz review - LGTY?

[gemini-code-assist]

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the maintainability and clarity of the toolset configuration, particularly for file system operations. It refactors the builtin toolset provider to reduce boilerplate code when registering FileSystemTools and standardizes the naming convention for these tools. Additionally, it includes minor cleanups such as removing a redundant method and updating a test method name.

Highlights

• Refactored Toolset Creation: Streamlined the process of creating built-in toolsets by directly using FileSystemTools.createToolSet(), eliminating repetitive individual tool registrations in the Tools.builtin method.
• Standardized Tool Naming: Updated FileSystemTools to use snake_case for tool keys (e.g., read_file instead of readFile) for improved consistency.
• Code Cleanup: Removed a redundant getListDirectory method from FileSystemTools and the final keyword from the FileSystemTools class declaration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request does a great job of cleaning up the FileSystemTools setup, removing repetition and making the code in Tools.java much cleaner and easier to maintain. The switch to snake_case for tool names is a good move for consistency with LLM conventions, and removing the duplicate getListDirectory method is a welcome cleanup. I have a couple of suggestions to further improve the design by making createToolSet an instance method, which would make the code more idiomatic and align better with object-oriented principles.

[temi-ro]

LGTM!