Skip to content

deps: Bump protobuf-java from 4.31.1 to 4.32.0 #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vorburger merged 1 commit into from
Sep 4, 2025
Merged

deps: Bump protobuf-java from 4.31.1 to 4.32.0 #1694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ enola_maven.install(
"com.google.truth.extensions:truth-java8-extension:1.4.4",
"com.google.truth.extensions:truth-proto-extension:1.4.4",
# Protobuf
"com.google.protobuf:protobuf-java:4.31.1",
"com.google.protobuf:protobuf-java-util:4.31.1",
"com.google.protobuf:protobuf-java:4.32.0",
"com.google.protobuf:protobuf-java-util:4.32.0",
Comment on lines +107 to +108
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Bumping the protobuf-java and protobuf-java-util versions to 4.32.0 creates a mismatch with the protoc compiler version being used in this project.

The protobuf-java version 4.32.0 corresponds to the protoc compiler version 27.2. However, the protobuf bazel dependency on line 28 is bazel_dep(name = "protobuf", version = "31.1"), which uses protoc version 27.1.

While protobuf generally maintains forward compatibility for the runtime, using a newer runtime with code generated by an older compiler is not ideal and can introduce subtle runtime issues. It's best practice to keep the compiler and runtime versions in sync.

I recommend checking if the protobuf bazel dependency can also be updated to a version that uses protoc 27.2. If not yet available, it might be better to hold off on this upgrade until both can be updated together to avoid potential compatibility problems.

Copy link
Copy Markdown
Member Author

@vorburger vorburger Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's coming hopefully soon in #1689, but I would like to get this in already first, just to see if it solves the problem there.

# gRPC
"io.grpc:grpc-netty:%s" % GRPC_JAVA_VERSION,
"io.grpc:grpc-stub:%s" % GRPC_JAVA_VERSION,
Expand Down
4 changes: 2 additions & 2 deletions docs/dev/dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ com.google.http-client:google-http-client-jackson2:1.45.3
com.google.j2objc:j2objc-annotations:3.0.0
com.google.jimfs:jimfs:1.3.1
com.google.oauth-client:google-oauth-client:1.37.0
com.google.protobuf:protobuf-java:4.31.1
com.google.protobuf:protobuf-java-util:4.31.1
com.google.protobuf:protobuf-java:4.32.0
com.google.protobuf:protobuf-java-util:4.32.0
com.google.re2j:re2j:1.7
com.google.truth.extensions:truth-java8-extension:1.4.4
com.google.truth.extensions:truth-liteproto-extension:1.4.4
Expand Down
16 changes: 8 additions & 8 deletions maven_install.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"__AUTOGENERATED_FILE_DO_NOT_MODIFY_THIS_FILE_MANUALLY": "THERE_IS_NO_DATA_ONLY_ZUUL",
"__INPUT_ARTIFACTS_HASH": -1000429227,
"__RESOLVED_ARTIFACTS_HASH": 1999662930,
"__INPUT_ARTIFACTS_HASH": -1849544363,
"__RESOLVED_ARTIFACTS_HASH": -415049589,
"conflict_resolution": {
"com.github.multiformats:java-multihash:d238c77f11a0ff33970ad43578ae11f049324848": "com.github.multiformats:java-multihash:1.3.6",
"com.google.guava:guava:33.4.0-jre": "com.google.guava:guava:33.4.8-jre"
Expand Down Expand Up @@ -746,17 +746,17 @@
},
"com.google.protobuf:protobuf-java": {
"shasums": {
"jar": "d60dfe7c68a0d38a248cca96924f289dc7e1966a887ee7cae397701af08575ae",
"sources": "0c1f6ecb409099c008358866086ea6e39f0f4b88e783ebb4c876ec0bbcee0e41"
"jar": "e902c91b454812b7d056b8d303a572733bf0587576ff157c1049116c9626241d",
"sources": "162377e7a9e66bd2d79991422492b724b6632728f662386c7d22162580e53e7f"
},
"version": "4.31.1"
"version": "4.32.0"
},
"com.google.protobuf:protobuf-java-util": {
"shasums": {
"jar": "fcdc37cac8738ae7f3a3bb4bc76f01517d16358dd3095a14f1e007d0fcc12a8c",
"sources": "90f488c896e1d3b9d7a4bdb44cab31fcb763c208cf06622aaa278d6373059bed"
"jar": "22b146afd08e92493402e992f5ea1f1f6300a9d5545b479d7ed1a08fb34555e1",
"sources": "91e92f090cc57abd22714bbe046f902c9f773324299e050c14000d0941f8b970"
},
"version": "4.31.1"
"version": "4.32.0"
},
"com.google.re2j:re2j": {
"shasums": {
Expand Down
Loading