deps: Bump protobuf-java from 4.31.1 to 4.32.0#1694
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine dependency upgrade for the Protobuf Java libraries. This update ensures the project benefits from the latest improvements, bug fixes, and security patches provided by the new version of Protobuf, maintaining compatibility and stability within the build system.
Highlights
- Protobuf-Java Dependency Update: The
protobuf-javaandprotobuf-java-utillibraries have been updated from version4.31.1to4.32.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
cbbcd3f to
730eb1d
Compare
There was a problem hiding this comment.
Code Review
This pull request updates protobuf-java and protobuf-java-util from version 4.31.1 to 4.32.0. While this is a minor update, I've identified a potential version mismatch between the protobuf runtime library and the protoc compiler version used in the project, which could lead to runtime issues. My review includes a comment detailing this concern and suggests aligning the versions for better stability.
| "com.google.protobuf:protobuf-java:4.32.0", | ||
| "com.google.protobuf:protobuf-java-util:4.32.0", |
There was a problem hiding this comment.
Bumping the protobuf-java and protobuf-java-util versions to 4.32.0 creates a mismatch with the protoc compiler version being used in this project.
The protobuf-java version 4.32.0 corresponds to the protoc compiler version 27.2. However, the protobuf bazel dependency on line 28 is bazel_dep(name = "protobuf", version = "31.1"), which uses protoc version 27.1.
While protobuf generally maintains forward compatibility for the runtime, using a newer runtime with code generated by an older compiler is not ideal and can introduce subtle runtime issues. It's best practice to keep the compiler and runtime versions in sync.
I recommend checking if the protobuf bazel dependency can also be updated to a version that uses protoc 27.2. If not yet available, it might be better to hold off on this upgrade until both can be updated together to avoid potential compatibility problems.
There was a problem hiding this comment.
That's coming hopefully soon in #1689, but I would like to get this in already first, just to see if it solves the problem there.
Relates to #1689 and #1635.