Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4: Kebab case attributes never trigger the attribute changed callback #5

Merged
merged 3 commits into from
May 2, 2024

Conversation

macdonst
Copy link
Contributor

@macdonst macdonst commented May 2, 2024

This PR checks to see if the attribute is kebab case and if so it converts the change callback to camel case.

@macdonst macdonst requested a review from kristoferjoseph May 2, 2024 15:12
index.mjs Outdated Show resolved Hide resolved
index.mjs Outdated Show resolved Hide resolved
macdonst added 2 commits May 2, 2024 11:29
Signed-off-by: macdonst <[email protected]>
Signed-off-by: macdonst <[email protected]>
@kristoferjoseph kristoferjoseph merged commit 961edb3 into main May 2, 2024
4 checks passed
@macdonst macdonst deleted the issue4 branch May 2, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants