New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser shim #2

Merged

macdonst merged 1 commit into main from shim

Oct 30, 2023

Contributor

macdonst commented Oct 30, 2023

Add the bare minimum browser definitions to allow the BaseElement to be SSR'd.


          Add browser shim

f4a1f44

Signed-off-by: macdonst <[email protected]>

macdonst requested review from kristoferjoseph and ryanbethel

October 30, 2023 02:24

ryanbethel approved these changes

View reviewed changes

ryanbethel left a comment

LGTM. We may need to shim a few more things in the future, but it makes sense to keep it thin to start with and only do more when they pop up.

kristoferjoseph approved these changes

View reviewed changes

macdonst merged commit d101f64 into main

4 checks passed

macdonst deleted the shim branch

October 30, 2023 20:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet