cmake: add options to disable vendored quazip, igraph, spdlog & pybind11#529
Merged
joern274 merged 1 commit intoemsec:masterfrom May 8, 2024
Merged
cmake: add options to disable vendored quazip, igraph, spdlog & pybind11#529joern274 merged 1 commit intoemsec:masterfrom
joern274 merged 1 commit intoemsec:masterfrom
Conversation
12 tasks
Contributor
Author
|
This is what we're currently using, so I may as well un-draft it. |
joern274
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch (mostly written by @doronbehar) we're using in the NixOS package for hal, where we have a policy of replacing those vendored dependencies we're sensibly able to with our own maintained versions (for reasons like security maintenance, patching to work around NixOS quirks, etc..).
Though I also understand that a lot of upstreams are awfully keen on their vendored dependencies, so we're fully prepared that you might not want to accept it.