hal-hardware-analyzer: 3.3.0 -> 4.2.0#251048
Merged
risicle merged 2 commits intoNixOS:masterfrom Aug 29, 2023
Merged
Conversation
this allows overrideAttrs to work better
doronbehar
reviewed
Aug 24, 2023
Contributor
doronbehar
left a comment
There was a problem hiding this comment.
Looks pretty good overall!
pkgs/applications/science/electronics/hal-hardware-analyzer/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/science/electronics/hal-hardware-analyzer/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/science/electronics/hal-hardware-analyzer/default.nix
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Looking closer at the built result of this, the Edit: fixed. |
4746af1 to
0edd410
Compare
0edd410 to
d189406
Compare
Contributor
Author
Contributor
doronbehar
approved these changes
Aug 28, 2023
Contributor
doronbehar
left a comment
There was a problem hiding this comment.
Changes look good, haven't tested. I trust OP have tested them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is largely the work of @doronbehar who wrote most of the de-vendoring patch used here (attempted upstreaming @ emsec/hal#529)
I still can't get this working on x86_64 darwin - it uses
open_memstreamand I can't getmemstreamHookfrom #135525 to fully solve the issues.But seeing as hal is currently totally broken on darwin, this is at least an improvement. Addresses #240729
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)