Skip to content

hal-hardware-analyzer: 3.3.0 -> 4.2.0#251048

Merged
risicle merged 2 commits intoNixOS:masterfrom
risicle:ris-hal-hardware-analyzer-4.2.0
Aug 29, 2023
Merged

hal-hardware-analyzer: 3.3.0 -> 4.2.0#251048
risicle merged 2 commits intoNixOS:masterfrom
risicle:ris-hal-hardware-analyzer-4.2.0

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Aug 23, 2023

Description of changes

This is largely the work of @doronbehar who wrote most of the de-vendoring patch used here (attempted upstreaming @ emsec/hal#529)

I still can't get this working on x86_64 darwin - it uses open_memstream and I can't get memstreamHook from #135525 to fully solve the issues.

But seeing as hal is currently totally broken on darwin, this is at least an improvement. Addresses #240729

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

this allows overrideAttrs to work better
@risicle risicle requested review from SCOTT-HAMILTON, doronbehar, dotlambda and jiegec and removed request for dotlambda and jiegec August 23, 2023 21:58
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 23, 2023
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall!

@risicle
Copy link
Contributor Author

risicle commented Aug 26, 2023

Looking closer at the built result of this, the graph_algorithms.so plugin is broken because it doesn't link with igraph. Will have to dig deeper.

Edit: fixed.

@risicle risicle marked this pull request as draft August 26, 2023 15:27
@risicle risicle force-pushed the ris-hal-hardware-analyzer-4.2.0 branch 2 times, most recently from 4746af1 to 0edd410 Compare August 27, 2023 15:20
@risicle risicle force-pushed the ris-hal-hardware-analyzer-4.2.0 branch from 0edd410 to d189406 Compare August 27, 2023 15:25
@risicle risicle marked this pull request as ready for review August 27, 2023 15:26
@risicle
Copy link
Contributor Author

risicle commented Aug 27, 2023

If @tobim wants to pull this in to #250435 instead that would be fine too.

@tobim
Copy link
Contributor

tobim commented Aug 27, 2023

If @tobim wants to pull this in to #250435 instead that would be fine too.

Nono, I just cherry-picked an earlier version of this PR to fix eval. Please continue.

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, haven't tested. I trust OP have tested them.

@risicle risicle merged commit a6f8a07 into NixOS:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants