Don't allow legacy settings in strict mode #8261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Mar 8, 2019
In strict mode (`EMCC_STRICT=1` or `-s STRICT`) treat any usage of legacy settings as an error. Also, move SAFE_HEAP and ASM_JS out of legacy settings. These settings are still used, they just need to have their values verified. See #8257
|
I wish we would revert this commit. This broke our use of MINIMAL_RUNTIME, and like we discussed before, it is not really a problem for a toolchain to allow enabling/specifying an option that has become a mandated default, instead it just improves more flexibile compatibility for build systems across Emscripten versions. |
|
Ah yes, I realized this might be a problem and #8411 was intended as the solution. Hopefully this will mean we can continue to evolve the meaning of STRICT without effecting users of MINIMAL_RUNTIME. At least the is the intention here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In strict mode (
EMCC_STRICT=1or-s STRICT) treat any usageof legacy settings as an error.
We don't even attach the legacy settings in this case so it becomes
impossible to depend on legacy settings.
See #8257