Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using -s STRICT to disable more legacy/compatibility behaviour #8317

Closed
sbc100 opened this issue Mar 20, 2019 · 1 comment
Closed

Using -s STRICT to disable more legacy/compatibility behaviour #8317

sbc100 opened this issue Mar 20, 2019 · 1 comment
Labels
wontfix

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Mar 20, 2019

Starting with #8261 I've been looking at disabling legacy / compatibility behaviour in s STRICT mode.

I hope to using this as a way to evolve the toolchain while at the same time allowing users who want backwards compatibility to continue as normal. This seems like a good match for what strict means in JS. i.e. dis-allow some old stuff and force me to use some new stuff.

I wanted to raise this with @juj after our discussion about backwards compatibility on #8034. I noticed that -s MINIMAL_RUNTIME currently implies -s STRICT. Perhaps we want to separate these two if -s STRICT is going to continue to gain more significance?

I looks like - STRICT=1 has also come to mean "don't include all default JS libraries", and perhaps that is why MINIMAL_RUNTIME defines -s STRICT? Perhaps we want to separate out that settings with some kind of new setting which means something like "NO_AUTO_LIBS".. perhaps we could also have it apply the native libraries too?
sbc100 added a commit that referenced this issue Apr 8, 2019
@sbc100
Separate STRICT from MINIMAL_RUNTIME
230e5b0 
This allows us to add more incompatibility checking to the STRICT
option without forcing it on all users or MINIMAL_RUNTIME.

This is part of #8317.

In particular we already already error on the use legacy settings
when in STRICT mode, but I understand that at least on major user (@juj)
wants to be able to continue to use legacy command line settings and
also wants to use MINIMAL_RUNTIME.
@sbc100 sbc100 mentioned this issue Apr 8, 2019
Merged
sbc100 added a commit that referenced this issue Apr 8, 2019
@sbc100
Separate STRICT from MINIMAL_RUNTIME
71ce045 
This allows us to add more incompatibility checking to the STRICT
option without forcing it on all users or MINIMAL_RUNTIME.

This is part of #8317.

In particular we already already error on the use legacy settings
when in STRICT mode, but I understand that at least on major user (@juj)
wants to be able to continue to use legacy command line settings and
also wants to use MINIMAL_RUNTIME.
sbc100 added a commit that referenced this issue Apr 8, 2019
@sbc100
DISABLE_DEPRECATED_FIND_EVENT_TARGET_BEHAVIOR in STRICT mode
cd119ba 
Part of #8317
@sbc100 sbc100 mentioned this issue Apr 8, 2019
Merged
sbc100 added a commit that referenced this issue Apr 8, 2019
@sbc100
Separate STRICT from MINIMAL_RUNTIME
c2f8909 
This allows us to add more incompatibility checking to the STRICT
option without forcing it on all users or MINIMAL_RUNTIME.

This is part of #8317.

In particular we already already error on the use legacy settings
when in STRICT mode, but I understand that at least on major user (@juj)
wants to be able to continue to use legacy command line settings and
also wants to use MINIMAL_RUNTIME.
sbc100 added a commit that referenced this issue Apr 8, 2019
@sbc100
Separate STRICT from MINIMAL_RUNTIME
008db61 
This allows us to add more incompatibility checking to the STRICT
option without forcing it on all users or MINIMAL_RUNTIME.

This is part of #8317.

In particular we already already error on the use legacy settings
when in STRICT mode, but I understand that at least on major user (@juj)
wants to be able to continue to use legacy command line settings and
also wants to use MINIMAL_RUNTIME.
sbc100 added a commit that referenced this issue Apr 9, 2019
@sbc100
Separate STRICT from MINIMAL_RUNTIME (#8411)
cb33ba9 
This allows us to add more incompatibility checking to the STRICT
option without forcing it on all users or MINIMAL_RUNTIME.

This is part of #8317.

In particular we already already error on the use legacy settings
when in STRICT mode, but I understand that at least on major user (@juj)
wants to be able to continue to use legacy command line settings and
also wants to use MINIMAL_RUNTIME.
sbc100 added a commit that referenced this issue Apr 10, 2019
@sbc100
DISABLE_DEPRECATED_FIND_EVENT_TARGET_BEHAVIOR in STRICT mode (#8413)
d91c4b8 
Part of #8317
@sbc100 sbc100 mentioned this issue May 8, 2019
Merged
sbc100 added a commit that referenced this issue May 14, 2019
@sbc100
Rename BINARYEN_ASYNC_COMPILATION -> WASM_ASYNC_COMPILATION
fc1c264 
Also, add a mechanism for supporting renamed settings.  This enables
users in non-strict mode to use with name for the settings, but users
in strict mode can only use the modern name.

Part of #8317
@sbc100 sbc100 mentioned this issue May 14, 2019
Merged
sbc100 added a commit that referenced this issue May 15, 2019
@sbc100
Rename BINARYEN_ASYNC_COMPILATION -> WASM_ASYNC_COMPILATION (#8601)
e33390f 
Also, add a mechanism for supporting renamed settings.  This enables
users in non-strict mode to use old name for the settings, but users
in strict mode must use the modern name.

Part of #8317
VirtualTim pushed a commit to VirtualTim/emscripten that referenced this issue May 21, 2019
@sbc100 @VirtualTim
Separate STRICT from MINIMAL_RUNTIME (emscripten-core#8411)
c2bb415 
This allows us to add more incompatibility checking to the STRICT
option without forcing it on all users or MINIMAL_RUNTIME.

This is part of emscripten-core#8317.

In particular we already already error on the use legacy settings
when in STRICT mode, but I understand that at least on major user (@juj)
wants to be able to continue to use legacy command line settings and
also wants to use MINIMAL_RUNTIME.
VirtualTim pushed a commit to VirtualTim/emscripten that referenced this issue May 21, 2019
@sbc100 @VirtualTim
DISABLE_DEPRECATED_FIND_EVENT_TARGET_BEHAVIOR in STRICT mode (emscrip…
7ebca1b 
…ten-core#8413)

Part of emscripten-core#8317
VirtualTim pushed a commit to VirtualTim/emscripten that referenced this issue May 21, 2019
@sbc100 @VirtualTim
Rename BINARYEN_ASYNC_COMPILATION -> WASM_ASYNC_COMPILATION (emscript…
9fe43d6 
…en-core#8601)

Also, add a mechanism for supporting renamed settings.  This enables
users in non-strict mode to use old name for the settings, but users
in strict mode must use the modern name.

Part of emscripten-core#8317
sbc100 added a commit that referenced this issue Aug 20, 2019
@sbc100
Add 'use strict' to generated JS when -s STRICT is used
f526210 
See #8317
@sbc100 sbc100 mentioned this issue Aug 20, 2019
Merged
sbc100 added a commit that referenced this issue Aug 21, 2019
@sbc100
Add 'use strict' to generated JS when -s STRICT is used (#9265)
2fe944f 
See #8317
@stale
Copy link

stale bot commented Mar 19, 2020

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Mar 19, 2020
@stale stale bot closed this as completed Mar 26, 2020
belraquib pushed a commit to belraquib/emscripten that referenced this issue Dec 23, 2020
@sbc100 @belraquib
Separate STRICT from MINIMAL_RUNTIME (emscripten-core#8411)
454a657 
This allows us to add more incompatibility checking to the STRICT
option without forcing it on all users or MINIMAL_RUNTIME.

This is part of emscripten-core#8317.

In particular we already already error on the use legacy settings
when in STRICT mode, but I understand that at least on major user (@juj)
wants to be able to continue to use legacy command line settings and
also wants to use MINIMAL_RUNTIME.
belraquib pushed a commit to belraquib/emscripten that referenced this issue Dec 23, 2020
@sbc100 @belraquib
DISABLE_DEPRECATED_FIND_EVENT_TARGET_BEHAVIOR in STRICT mode (emscrip…
1c571b4 
…ten-core#8413)

Part of emscripten-core#8317
belraquib pushed a commit to belraquib/emscripten that referenced this issue Dec 23, 2020
@sbc100 @belraquib
Rename BINARYEN_ASYNC_COMPILATION -> WASM_ASYNC_COMPILATION (emscript…
152f886 
…en-core#8601)

Also, add a mechanism for supporting renamed settings.  This enables
users in non-strict mode to use old name for the settings, but users
in strict mode must use the modern name.

Part of emscripten-core#8317
belraquib pushed a commit to belraquib/emscripten that referenced this issue Dec 23, 2020
@sbc100 @belraquib
Add 'use strict' to generated JS when -s STRICT is used (emscripten…
46aff8b 
…-core#9265)

See emscripten-core#8317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbc100