Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm64] Use bigint index types for memory and table under wasm64 #22497

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[wasm64] Use bigint index types for memory and table under wasm64 #22497

merged 1 commit into from
Sep 5, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 3, 2024 •
edited
Loading

Recent versions of firefox started requiring bigint values for initial and max memory and chrome will do soon too.

This fixes the bad Memory initial size that has been reported under firefox

See WebAssembly/memory64#68

Fixes: #22486

@sbc100 sbc100 requested a review from dschuff September 3, 2024 22:48
@sbc100 sbc100 force-pushed the memory64_bounds branch 2 times, most recently from 8b39774 to a14804c Compare September 3, 2024 22:53
dschuff
dschuff approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd make the commit title say what the change actually does (and put the reason, i.e. "fix for this error") in the description instead.

@sbc100 sbc100 changed the title [wasm64] Fix for bad Memory initial size under firefox [wasm64] Use bigint values of memory bounds under wasm64 Sep 4, 2024
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 4, 2024

LGTM, but I'd make the commit title say what the change actually does (and put the reason, i.e. "fix for this error") in the description instead.

Done, PTAL

@sbc100 sbc100 enabled auto-merge (squash) September 4, 2024 00:24
@sbc100 sbc100 changed the title [wasm64] Use bigint values of memory bounds under wasm64 [wasm64] Use bigint values for memory bounds under wasm64 Sep 4, 2024
@dschuff
Copy link
Member

dschuff commented Sep 4, 2024

LGTM, thanks

sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 4, 2024
@sbc100
Simplify from64 macro
70ad5f1 
Also, add a variant that simply generates an expression, similar to how
the `to64` macro works.  This is needed for emscripten-core#22497
@sbc100 sbc100 mentioned this pull request Sep 4, 2024
Merged
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 4, 2024
@sbc100
Simplify from64 macro
401f7be 
Also, add a variant that simply generates an expression, similar to how
the `to64` macro works.  This is needed for emscripten-core#22497
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 4, 2024
@sbc100
Simplify from64 macro
2e84759 
Also, add a variant that simply generates an expression, similar to how
the `to64` macro works.  This is needed for emscripten-core#22497
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 4, 2024
@sbc100
Simplify from64 macro
a7f5361 
Also, add a variant that simply generates an expression, similar to how
the `to64` macro works.  This is needed for emscripten-core#22497
@sbc100 sbc100 changed the title [wasm64] Use bigint values for memory bounds under wasm64 [wasm64] Use bigint index types for memory and table under wasm64 Sep 4, 2024
sbc100 added a commit that referenced this pull request Sep 4, 2024
@sbc100
Simplify from64 macro (#22504)
841c481 
Also, add a variant that simply generates an expression, similar to how
the `to64` macro works. This is needed for #22497
@sbc100 sbc100 force-pushed the memory64_bounds branch 5 times, most recently from 625221f to 0b59e0d Compare September 5, 2024 19:27
@sbc100
[wasm64] Fix for bad Memory initial size under firefox
05921c5 
Recent versions of firefox started requiring bigint values for initial
and max memory.

See WebAssembly/memory64#68

Fixes: emscripten-core#22486
@sbc100 sbc100 merged commit 12770b1 into emscripten-core:main Sep 5, 2024
28 checks passed
@sbc100 sbc100 deleted the memory64_bounds branch September 5, 2024 20:57
sbc100 added a commit to sbc100/emscripten that referenced this pull request Oct 1, 2024
@sbc100
Add toIndexType when calling Memory.grow
94461fa 
This was missing from emscripten-core#22497 and is currently causing
test_embind_o2_mem_growth_wasm64 to fail with the latest nightly version
of d8.
@sbc100 sbc100 mentioned this pull request Oct 1, 2024
Merged
sbc100 added a commit to sbc100/emscripten that referenced this pull request Oct 1, 2024
@sbc100
Add toIndexType when calling Memory.grow
1fa5ab1 
This was missing from emscripten-core#22497 and is currently causing
test_embind_o2_mem_growth_wasm64 to fail with the latest nightly version
of d8.
sbc100 added a commit that referenced this pull request Oct 1, 2024
@sbc100
Add toIndexType when calling Memory.grow (#22666)
e965961 
This was missing from #22497 and is currently causing
test_embind_o2_mem_growth_wasm64 to fail with the latest nightly version
of d8.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Oct 11, 2024
@sbc100
Use toIndexType in minimal runtime
1e8919d 
This fixes the MINIMAL_RUNTIME + MEMORY64 + IMPORTED_MEMORY.

See emscripten-core#22497
sbc100 added a commit to sbc100/emscripten that referenced this pull request Oct 11, 2024
@sbc100
Use toIndexType in minimal runtime
aa048a4 
This fixes the MINIMAL_RUNTIME + MEMORY64 + IMPORTED_MEMORY.

See emscripten-core#22497
@sbc100 sbc100 mentioned this pull request Oct 11, 2024
Merged
sbc100 added a commit to sbc100/emscripten that referenced this pull request Oct 11, 2024
@sbc100
Use toIndexType in minimal runtime
930079d 
This fixes the MINIMAL_RUNTIME + MEMORY64 + IMPORTED_MEMORY.

See emscripten-core#22497
sbc100 added a commit that referenced this pull request Oct 11, 2024
@sbc100
Use toIndexType in minimal runtime (#22724)
38cad97 
This fixes the MINIMAL_RUNTIME + MEMORY64 + IMPORTED_MEMORY.

See #22497
@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @dschuff