Allow more features for maybe-wasm2js and wasm-split #22799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for alloing bulk memory and nontrapping-fp by default. Maybe-wasm2js just allows all features for simplicity (although if a feature unsupported by wasm2js is used, the test may fail anyway). The wasm-split test fails when reference types are enabled; I haven't investigated that yet, but for now we just enable the 2 we are interested in.
dschuff
changed the title
|
also /cc @tlively |
kripken
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow more features for maybe-wasm2js and wasm-split
This is in preparation for alloing bulk memory and nontrapping-fp by default.
Maybe-wasm2js just allows all features for simplicity (although if a feature
unsupported by wasm2js is used, the test may fail anyway).
The wasm-split test fails when reference types are enabled; I haven't
investigated that yet, but for now we just enable the 2 we are interested in.