Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ Current Trunk
things about how LLVM optimizes and inlines, so it may cause noticeable
changes in compile times, code size, and speed, either for better or for
worse. (#13427)
- Removed use of Python multiprocessing library because of stability issues. Added
new environment variable EM_PYTHON_MULTIPROCESSING=1 that can be enabled
to revert back to using Python multiprocessing. (#13493)
- Removed use of Python multiprocessing library because of stability issues.
Added a new environment variable `EM_PYTHON_MULTIPROCESSING=1` that can be set
to revert back to using Python multiprocessing, in case there are reports of
regressions (that variable is intended to be temporary). (#13493)
- Binaryen now always inlines single-use functions. This should reduce code size
and improve performance (#13744).
- Fix generating of symbol files with `--emit-symbol-map` for JS targets.
Expand Down
11 changes: 9 additions & 2 deletions tests/test_other.py
Original file line number Diff line number Diff line change
Expand Up @@ -2274,8 +2274,9 @@ def test_conftest_s_flag_passing(self):
return 0;
}
''')
with env_modify({'EMMAKEN_JUST_CONFIGURE': '1'}):
cmd = [EMCC, '-s', 'ASSERTIONS', 'conftest.c', '-o', 'conftest']
# the name "conftest.c" is enough to make us use a configure-like mode,
# the same as if EMMAKEN_JUST_CONFIGURE=1 were set in the env.
cmd = [EMCC, '-s', 'ASSERTIONS', 'conftest.c', '-o', 'conftest']
output = self.run_process(cmd, stderr=PIPE)
self.assertNotContained('emcc: warning: treating -s as linker option', output.stderr)
self.assertExists('conftest')
Expand Down Expand Up @@ -10256,3 +10257,9 @@ def test_output_name_collision(self):
self.assertExists('hello.wasm')
self.assertExists('hello_.wasm')
self.assertContained('hello, world!', self.run_js('hello.wasm'))

def test_EM_PYTHON_MULTIPROCESSING(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this really is just a temporary thing perhaps mention in changelog why it was added and that is just a transitional thing to help people temporarily revert?

with env_modify({'EM_PYTHON_MULTIPROCESSING': '1'}):
# wasm2js optimizations use multiprocessing to run multiple node
# invocations
self.run_process([EMCC, test_file('hello_world.c'), '-sWASM=0', '-O2'])