Add a test for EM_PYTHON_MULTIPROCESSING #13832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Apr 6, 2021
tests/test_other.py
Outdated
| with env_modify({'EMMAKEN_JUST_CONFIGURE': '1'}): | ||
| cmd = [EMCC, '-s', 'ASSERTIONS', 'conftest.c', '-o', 'conftest'] | ||
| output = self.run_process(cmd, stderr=PIPE) | ||
| output = self.run_process(cmd, stderr=PIPE) |
Collaborator
There was a problem hiding this comment.
I guess that env_modify is not needed here since the filename (conftest.c) is enough of signal to run in this mode? Maybe just remove the with and replac with a comment?
| self.assertExists('hello_.wasm') | ||
| self.assertContained('hello, world!', self.run_js('hello.wasm')) | ||
|
|
||
| def test_EM_PYTHON_MULTIPROCESSING(self): |
Collaborator
There was a problem hiding this comment.
If this really is just a temporary thing perhaps mention in changelog why it was added and that is just a transitional thing to help people temporarily revert?
Member
Author
|
Thanks, feedback addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13493
Also contains a drive-by fix for a test that used
env_modifyincorrectly.