Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-italian-translation #296

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Conversation

mavmaf
Copy link
Contributor

@mavmaf mavmaf commented Jul 3, 2023

Motivation and context

Adding IT texts to archetype
Clear-search-input button class modified
Pending to resolve: https://searchbroker.atlassian.net/browse/EX-7225 -> empathyco/x#791

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@mavmaf mavmaf requested a review from a team as a code owner July 3, 2023 12:12
@jenkins-empathy
Copy link

PR #296 preview deployed in https://x.test.empathy.co/preview/296/index.html

@jenkins-empathy
Copy link

PR #296 preview deployed in https://x.test.empathy.co/preview/296/index.html

@jenkins-empathy
Copy link

PR #296 preview deployed in https://x.test.empathy.co/preview/296/index.html

@mavmaf mavmaf requested a review from annacv July 4, 2023 09:19
@jenkins-empathy
Copy link

PR #296 preview deployed in https://x.test.empathy.co/preview/296/index.html

Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@mavmaf mavmaf merged commit de0f46e into main Jul 4, 2023
2 checks passed
@mavmaf mavmaf deleted the feature/EMP-1345-add-it-texts branch July 4, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants