-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: My History dates locale should rely on uiLang #791
Comments
Hi, I want to work on this issue. I'm new to open source |
Hello @Dhananjay-12 I am assigning this issue to you. Sorry about not answering sooner! |
Hello @Dhananjay-12, I am unassigning you as it seems you couldn't start the PR. Thanks! |
Is this issue still open ? |
Yes @Tanmay3132 , go for it ;) |
Hey, can I work on this? |
All yours, @vbsh123 :) |
@herrardo, this issue still seems to be open. I'd like to contribute! |
Please go ahead! |
Made a PR: #1638 |
How can the project be improved?
Some commits ago, the uiLang parameter was added to the
SnippetConfig
.This was made because now, the requests to the APIs rely in
lang
parameter, and if exist the lang shown by the UI components rely in the newuiLang
parameter, so the components can have different locale for requests and UI using both parameters.How can this be solved?
Change the MyHistory component to show dates based in
uiLang
instead oflang
as locale.Proposed solution
No response
Customizations supported
No response
Additional information
Make the first character of the date always uppercase to show
Miércoles, 19 de octubre de 2022
instead of
miércoles, 19 de octubre de 2022
In English the first is uppercase, but just because names of days and months are uppercase in English and
toLocaleDateString
is setting that in the right way. But in Spanish, or other languages, even if the name of the day is correctly written in lowercase, we would like to start the sentence in uppercase.Code of Conduct
The text was updated successfully, but these errors were encountered: