Clarify platform-specific details for Viewport positioning#5715
Merged
lucasmerlin merged 4 commits intoemilk:masterfrom Feb 20, 2025
Merged
Clarify platform-specific details for Viewport positioning#5715lucasmerlin merged 4 commits intoemilk:masterfrom
Viewport positioning#5715lucasmerlin merged 4 commits intoemilk:masterfrom
Conversation
ViewportsViewport positioning
|
Preview available at https://egui-pr-preview.github.io/pr/5715-viewport-position-docs |
lucasmerlin
approved these changes
Feb 20, 2025
Collaborator
lucasmerlin
left a comment
There was a problem hiding this comment.
Ah, should've realized in the first review, we should mention that this is eframe specific, since it might be different for someone e.g. using bevy_egui. I'll apply the suggestions and merge this now, thanks!
lucasmerlin
reviewed
Feb 20, 2025
darkwater
pushed a commit
to darkwater/egui
that referenced
this pull request
Aug 24, 2025
) On Wayland (and android apparently) it is not possible for applications to position their windows or request the window position (for some reason). This is not specified in the documentation. proof: [`winit::set_outer_position`], [`winit::outer_position`], [`winit::inner_position`] all specify that Android / Wayland are not supported. [`winit::set_outer_position`]: https://docs.rs/winit/latest/winit/window/struct.Window.html#method.set_outer_position [`winit::outer_position`]: https://docs.rs/winit/latest/winit/window/struct.Window.html#method.outer_position [`winit::inner_position`]: https://docs.rs/winit/latest/winit/window/struct.Window.html#method.inner_position * Maybe closes emilk#4469 * the lack of support makes me sad. I believe this makes some items in emilk#3556 impossible on Wayland. Oh well! --------- Co-authored-by: lucasmerlin <lucasmeurer96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wayland (and android apparently) it is not possible for applications to position their windows or request the window position (for some reason). This is not specified in the documentation.
proof:
winit::set_outer_position,winit::outer_position,winit::inner_positionall specify that Android / Wayland are not supported.with_positionmethod of ViewportBuilder does not seem to work on wayland #4469