Fix: The viewport stops working when the program is minimized. #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Jul 31, 2024
Comment on lines
+192
to
+193
| window.request_redraw(); | ||
| true |
There was a problem hiding this comment.
This reverts the changes you added in:
Won't this cause high CPU usage on Windows when minimized again?
There was a problem hiding this comment.
Yes, it's ok as long as you don't keep calling request_repaint().
There was a problem hiding this comment.
If someone want to keep calling request_repaint() but not call it when minimized, someone can do the following.
It works fine.
let is_maximized = ui.input(|i| i.viewport().maximized.unwrap_or(false));
if !is_minimized {
ui.ctx().request_repaint();
}
emilk
pushed a commit
that referenced
this pull request
Sep 1, 2024
Fix: The viewport stops working when the program is minimized.
Fix: Logically, the weird parts have been normalized.
**Issue :**
The viewport stops working when the program is minimized.
* Related #3321
* Related #3877
* Related #3985
* Closes #3972
* Closes #4772
* Related #4832
* Closes #4892
**Solution :**
When `request_redraw()` is performed in Minimized state, the occasional
screen tearing phenomenon has disappeared.
( Probably expected to be the effect of #4814 )
To address the issue of the `Immediate Viewport` not updating in
Minimized state, we can call `request_redraw()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: The viewport stops working when the program is minimized.
Issue :
The viewport stops working when the program is minimized.
Solution :
When
request_redraw()is performed in Minimized state, the occasional screen tearing phenomenon has disappeared.( Probably expected to be the effect of #4814 )
To address the issue of the
Immediate Viewportnot updating in Minimized state, we can callrequest_redraw().