Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "DragValue: when keyboard editing, only update the value on focus lost" #2879

Closed
wants to merge 1 commit into from
Closed

Revert "DragValue: when keyboard editing, only update the value on focus lost" #2879

wants to merge 1 commit into from

Conversation

Barugon
Copy link
Contributor

@Barugon Barugon commented Apr 6, 2023

Reverts #2688, which causes a lot of problems with DragValue editing (see #2818).

@Barugon
Copy link
Contributor Author

Barugon commented Apr 6, 2023

Actually, a better solution would be to use Response::changed so that the value isn't being parsed every frame. I'm closing this PR in order to create a new PR with that change.

@Barugon Barugon closed this Apr 6, 2023
@Barugon Barugon deleted the revert-2688-drag_value_only_update_on_focus_lost branch April 6, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant