DragValue edit is discarded when clicked off

[Barugon]

Describe the bug
If I click a DragValue and type in a new value then that new value is discarded if I click on another DragValue or TextEdit.

Video: https://youtube.com/shorts/_wxqB0XjkIY

[paul-hansen]

This is really annoying when you want to edit a list of values with the keyboard by tabbing through them. The only way to make the changes save is to hit the return key, which resets the tabbing state so you have to tab back to where you were from the start.

For example, I have this Ui:

I would like to be able to select the first value (translation.x), type the new value, hit tab, type the next value, hit tab, etc. Currently that's not possible as it doesn't save the values you typed when you hit tab.

This used to work so likely a regression.

[Barugon]

I'm using the return key to mean "Ok" when displaying a dialog (standard OS behavior) so using it to enter a single value is not good.

This used to work so likely a regression.

This is for sure a regression.

[paul-hansen]

Looks like it was introduced in this commit: b40dba1

Used git bisect and tested with the hello_world example to find the first commit where it wasn't working. The drag value created by the Slider in the example is affected so it made a good test since DragValue isn't used in the examples directly.

[Barugon]

The problem here seems to be that Memory doesn't see that the TextEdit has lost focus.

[Barugon]

Okay, I found the culprit. If you click on another DragValue or TextEdit then Memory::stop_text_input gets called, which sets the focus ID to None. This happens before this check, so is_kb_editing is false, which essentially kills the edit session.

Clicking on other widgets (e.g. Label) does not call Memory::stop_text_input, which allows Memory::surrender_focus to be executed correctly, resulting in the correct behavior.

Simply commenting out this line fixes the issue but I don't know if there would be any other issues because of it.
@emilk

[edit] Doesn't fix tabbing.

[Barugon]

Tabbing between DragValues also disregards any edit.

[Barugon]

I honestly feel that #2688 is just too problematic and should be reverted.