Skip to content

Bump OpenTelemetry.Instrumentation.AspNetCore and 2 others#36

Merged
emeraldleaf merged 1 commit into
mainfrom
dependabot/nuget/opentelemetry-4506789609
Jun 3, 2026
Merged

Bump OpenTelemetry.Instrumentation.AspNetCore and 2 others#36
emeraldleaf merged 1 commit into
mainfrom
dependabot/nuget/opentelemetry-4506789609

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 26, 2026

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Pinned OpenTelemetry.Instrumentation.AspNetCore at 1.15.2.

Release notes

Sourced from OpenTelemetry.Instrumentation.AspNetCore's releases.

1.15.2

1.15.1

1.15.1-beta.2

1.15.1-beta.1

1.15.1-alpha.1

Commits viewable in compare view.

Pinned OpenTelemetry.Instrumentation.Http at 1.15.1.

Release notes

Sourced from OpenTelemetry.Instrumentation.Http's releases.

1.15.1

1.15.1-beta.2

1.15.1-beta.1

1.15.1-alpha.1

Commits viewable in compare view.

Pinned OpenTelemetry.Instrumentation.Runtime at 1.15.1.

Release notes

Sourced from OpenTelemetry.Instrumentation.Runtime's releases.

1.15.1

1.15.1-beta.2

1.15.1-beta.1

1.15.1-alpha.1

Commits viewable in compare view.

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github May 26, 2026

Labels

The following labels could not be found: dependencies, nuget. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot Bot requested a review from emeraldleaf as a code owner May 26, 2026 05:27
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dependabot dependabot Bot changed the title Bump the opentelemetry group with 3 updates Bump OpenTelemetry.Instrumentation.AspNetCore and 2 others May 31, 2026
@dependabot dependabot Bot force-pushed the dependabot/nuget/opentelemetry-4506789609 branch from 4937887 to b48110c Compare May 31, 2026 22:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

This PR bumps centralized OpenTelemetry instrumentation package versions and adds corresponding PackageReference entries in the OrderService project to consume those instrumentation packages.

Changes

OpenTelemetry Instrumentation Setup

Layer / File(s) Summary
Central package version updates
Directory.Packages.props
OpenTelemetry instrumentation package versions are bumped: OpenTelemetry.Instrumentation.AspNetCore → 1.15.2; OpenTelemetry.Instrumentation.Http, OpenTelemetry.Instrumentation.Runtime → 1.15.1.
OrderService instrumentation references
OrderService/OrderService.csproj
Adds PackageReference entries for OpenTelemetry.Instrumentation.AspNetCore, OpenTelemetry.Instrumentation.Http, and OpenTelemetry.Instrumentation.Runtime.

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers:

  • emeraldleaf
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: bumping three OpenTelemetry instrumentation packages to newer versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/nuget/opentelemetry-4506789609

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 31, 2026
@dependabot dependabot Bot force-pushed the dependabot/nuget/opentelemetry-4506789609 branch from b48110c to eec3146 Compare May 31, 2026 22:38
@dependabot dependabot Bot force-pushed the dependabot/nuget/opentelemetry-4506789609 branch from eec3146 to 009232e Compare June 1, 2026 01:04
@dependabot dependabot Bot force-pushed the dependabot/nuget/opentelemetry-4506789609 branch from 009232e to 91b64a2 Compare June 1, 2026 01:23
@emeraldleaf
Copy link
Copy Markdown
Owner

@dependabot rebase

1 similar comment
@emeraldleaf
Copy link
Copy Markdown
Owner

@dependabot rebase

@dependabot dependabot Bot force-pushed the dependabot/nuget/opentelemetry-4506789609 branch from 91b64a2 to e173988 Compare June 1, 2026 02:23
@emeraldleaf
Copy link
Copy Markdown
Owner

@dependabot rebase

Bumps OpenTelemetry.Instrumentation.AspNetCore from 1.15.0 to 1.15.2
Bumps OpenTelemetry.Instrumentation.Http from 1.15.0 to 1.15.1
Bumps OpenTelemetry.Instrumentation.Runtime from 1.15.0 to 1.15.1

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.AspNetCore
  dependency-version: 1.15.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: opentelemetry
- dependency-name: OpenTelemetry.Instrumentation.Http
  dependency-version: 1.15.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: opentelemetry
- dependency-name: OpenTelemetry.Instrumentation.Runtime
  dependency-version: 1.15.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: opentelemetry
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/nuget/opentelemetry-4506789609 branch from e173988 to fe984f6 Compare June 2, 2026 03:15
emeraldleaf added a commit that referenced this pull request Jun 2, 2026
…isfy S3241 (#64)

Main has been broken since #63 (analyzers bump) landed — SonarAnalyzer's
S3241 rule now fires on three pre-existing private extension methods in
NextAurora.ServiceDefaults/Extensions.cs that return TBuilder but whose
callers ignore the return value:

  - AddOpenTelemetryExporters<TBuilder>     (line 107)
  - AddDefaultAuthentication<TBuilder>       (line 169)
  - AddNextAuroraApiVersioning<TBuilder>     (line 234)

S3241: "Change return type to 'void'; not a single caller uses the
returned value."

Every Dependabot rebase since #63 has been failing CI with the same
three errors, blocking #35, #36, #61 from merging. Unblocks the queue.

The rule is correct — all three were called as statements
(`builder.AddOpenTelemetryExporters();`) with the return discarded.
Changes the return type to `void`, drops the `return builder;` lines
(and converts the early-return in AddDefaultAuthentication from
`return builder;` to bare `return;`).

No behavior change. No caller change. Build green locally.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
@emeraldleaf emeraldleaf merged commit 357be3a into main Jun 3, 2026
3 of 6 checks passed
@emeraldleaf emeraldleaf deleted the dependabot/nuget/opentelemetry-4506789609 branch June 3, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant