Skip to content

[Instrumentation.Wcf] Revert System.Security.Cryptography.Xml#4266

Merged
martincostello merged 3 commits intoopen-telemetry:mainfrom
Kielek:revert-xml-bump-wcf
Apr 22, 2026
Merged

[Instrumentation.Wcf] Revert System.Security.Cryptography.Xml#4266
martincostello merged 3 commits intoopen-telemetry:mainfrom
Kielek:revert-xml-bump-wcf

Conversation

@Kielek
Copy link
Copy Markdown
Member

@Kielek Kielek commented Apr 22, 2026

Changes

Reverts #4103.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions Bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf labels Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (a545405) to head (956fbbf).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4266      +/-   ##
==========================================
- Coverage   73.85%   73.82%   -0.04%     
==========================================
  Files         459      467       +8     
  Lines       18327    18369      +42     
==========================================
+ Hits        13535    13560      +25     
- Misses       4792     4809      +17     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 89.38% <ø> (ø)
unittests-Exporter.Geneva 55.14% <ø> (+0.30%) ⬆️
unittests-Exporter.InfluxDB 95.81% <ø> (ø)
unittests-Exporter.Instana 74.86% <ø> (ø)
unittests-Exporter.OneCollector 94.61% <ø> (ø)
unittests-Extensions 90.78% <ø> (ø)
unittests-Extensions.Enrichment 100.00% <ø> (ø)
unittests-Extensions.Enrichment.AspNetCore 86.27% <ø> (ø)
unittests-Extensions.Enrichment.Http 94.33% <ø> (ø)
unittests-Instrumentation.AWS 83.54% <ø> (ø)
unittests-Instrumentation.AspNet 76.61% <ø> (ø)
unittests-Instrumentation.AspNetCore 70.44% <ø> (ø)
unittests-Instrumentation.Cassandra 23.52% <ø> (?)
unittests-Instrumentation.ConfluentKafka 47.37% <ø> (ø)
unittests-Instrumentation.ElasticsearchClient 80.60% <ø> (ø)
unittests-Instrumentation.EntityFrameworkCore 81.39% <ø> (ø)
unittests-Instrumentation.EventCounters 77.27% <ø> (ø)
unittests-Instrumentation.GrpcCore 91.27% <ø> (ø)
unittests-Instrumentation.GrpcNetClient 73.78% <ø> (ø)
unittests-Instrumentation.Hangfire 86.05% <ø> (ø)
unittests-Instrumentation.Http 74.62% <ø> (ø)
unittests-Instrumentation.Owin 88.62% <ø> (ø)
unittests-Instrumentation.Process 100.00% <ø> (ø)
unittests-Instrumentation.Quartz 78.76% <ø> (ø)
unittests-Instrumentation.Remoting 64.28% <ø> (ø)
unittests-Instrumentation.Runtime 100.00% <ø> (ø)
unittests-Instrumentation.ServiceFabricRemoting 40.83% <ø> (ø)
unittests-Instrumentation.SqlClient 85.21% <ø> (ø)
unittests-Instrumentation.StackExchangeRedis 93.63% <ø> (ø)
unittests-Instrumentation.Wcf 80.64% <ø> (-0.14%) ⬇️
unittests-OpAmp.Client 83.03% <ø> (+0.44%) ⬆️
unittests-PersistentStorage 68.81% <ø> (-0.33%) ⬇️
unittests-Resources.AWS 74.49% <ø> (ø)
unittests-Resources.Azure 88.31% <ø> (ø)
unittests-Resources.Container 67.34% <ø> (ø)
unittests-Resources.Gcp 71.42% <ø> (ø)
unittests-Resources.Host 72.26% <ø> (ø)
unittests-Resources.OperatingSystem 76.98% <ø> (ø)
unittests-Resources.Process 100.00% <ø> (ø)
unittests-Resources.ProcessRuntime 79.59% <ø> (ø)
unittests-Sampler.AWS 94.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek marked this pull request as ready for review April 22, 2026 08:06
@Kielek Kielek requested a review from a team as a code owner April 22, 2026 08:06
@Kielek Kielek force-pushed the revert-xml-bump-wcf branch from c6a0bc3 to 818ba58 Compare April 22, 2026 08:07
@Kielek Kielek force-pushed the revert-xml-bump-wcf branch from 818ba58 to 2b9f0a7 Compare April 22, 2026 08:09
Comment thread src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md Outdated
@Kielek Kielek enabled auto-merge April 22, 2026 08:25
@Kielek Kielek added this pull request to the merge queue Apr 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 22, 2026
@martincostello martincostello added this pull request to the merge queue Apr 22, 2026
@martincostello
Copy link
Copy Markdown
Member

martincostello commented Apr 22, 2026

#4169 will hopefully fix the flaky tests that use TestHttpServer.

Nope, different failure mode.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 22, 2026
@martincostello martincostello added this pull request to the merge queue Apr 22, 2026
@martincostello
Copy link
Copy Markdown
Member

#4277

Merged via the queue into open-telemetry:main with commit 262a8f1 Apr 22, 2026
637 of 639 checks passed
@Kielek Kielek deleted the revert-xml-bump-wcf branch April 22, 2026 09:53
intellitect-bot pushed a commit to IntelliTect/EssentialCSharp.Web that referenced this pull request Apr 22, 2026
Updated
[OpenTelemetry.Instrumentation.Runtime](https://github.com/open-telemetry/opentelemetry-dotnet-contrib)
from 1.15.0 to 1.15.1.

<details>
<summary>Release notes</summary>

_Sourced from [OpenTelemetry.Instrumentation.Runtime's
releases](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)._

## 1.15.1

* NuGet: [OpenTelemetry.Instrumentation.AspNet
v1.15.1](https://www.nuget.org/packages/OpenTelemetry.Instrumentation.AspNet/1.15.1)

   No notable changes.

See
[CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Instrumentation.AspNet-1.15.1/src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md)
for details.
* NuGet: [OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule
v1.15.1](https://www.nuget.org/packages/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/1.15.1)

  * Propagate baggage before `Activity` is created.

([#​3820](open-telemetry/opentelemetry-dotnet-contrib#3820))

See
[CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Instrumentation.AspNet-1.15.1/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/CHANGELOG.md)
for details.


## 1.15.1-beta.2

* NuGet: [OpenTelemetry.Instrumentation.Wcf
v1.15.1-beta.2](https://www.nuget.org/packages/OpenTelemetry.Instrumentation.Wcf/1.15.1-beta.2)

* Revert `System.Security.Cryptography.Xml` dependency version update
for
.NET 8, 9, and 10 to `4.7.1` released in 1.15.1-beta.1 introduced in
[#​4103](open-telemetry/opentelemetry-dotnet-contrib#4103).

([#​4266](open-telemetry/opentelemetry-dotnet-contrib#4266))

See
[CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Instrumentation.Wcf-1.15.1-beta.2/src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md)
for details.


## 1.15.1-beta.1

* NuGet: [OpenTelemetry.Extensions.Enrichment
v1.15.1-beta.1](https://www.nuget.org/packages/OpenTelemetry.Extensions.Enrichment/1.15.1-beta.1)

  * Updated OpenTelemetry core component version(s) to `1.15.3`.

([#​4166](open-telemetry/opentelemetry-dotnet-contrib#4166))
  
* Fixed trace enrichment callbacks so exceptions thrown by user-provided
enrichers or enrichment actions no longer interrupt trace processing.

([#​4165](open-telemetry/opentelemetry-dotnet-contrib#4165))

See
[CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Extensions.Enrichment-1.15.1-beta.1/src/OpenTelemetry.Extensions.Enrichment/CHANGELOG.md)
for details.


## 1.15.1-alpha.1

* NuGet: [OpenTelemetry.Instrumentation.EventCounters
v1.15.1-alpha.1](https://www.nuget.org/packages/OpenTelemetry.Instrumentation.EventCounters/1.15.1-alpha.1)

  * Updated OpenTelemetry core component version(s) to `1.15.3`.

([#​4166](open-telemetry/opentelemetry-dotnet-contrib#4166))

See
[CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/Instrumentation.EventCounters-1.15.1-alpha.1/src/OpenTelemetry.Instrumentation.EventCounters/CHANGELOG.md)
for details.


Commits viewable in [compare
view](open-telemetry/opentelemetry-dotnet-contrib@Exporter.OneCollector-1.15.0...Instrumentation.AspNet-1.15.1).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=OpenTelemetry.Instrumentation.Runtime&package-manager=nuget&previous-version=1.15.0&new-version=1.15.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants