Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable parallelization of @embroider/macros in non-Embroider builds #865

Merged
merged 4 commits into from
Jun 24, 2021
Merged

Enable parallelization of @embroider/macros in non-Embroider builds #865

merged 4 commits into from
Jun 24, 2021

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Jun 18, 2021 •
edited by rwjblue
Loading

Closes #671

@thoov thoov changed the title [WIP] Fix parallelization for @embroider/macros Fix parallelization for @embroider/macros Jun 21, 2021
@thoov thoov added the enhancement New feature or request label Jun 21, 2021
@thoov thoov changed the title Fix parallelization for @embroider/macros Enable parallelization of @embroider/macros Jun 21, 2021
@thoov thoov mentioned this pull request Jun 23, 2021
Merged
@rwjblue
Copy link
Collaborator

rwjblue commented Jun 24, 2021

Ready for a rebase

@thoov
Copy link
Collaborator Author

thoov commented Jun 24, 2021

Ready for a rebase

Done

@rwjblue rwjblue changed the title Enable parallelization of @embroider/macros Enable parallelization of @embroider/macros in non-Embroider builds Jun 24, 2021
@rwjblue rwjblue added bug Something isn't working and removed enhancement New feature or request labels Jun 24, 2021
@rwjblue rwjblue merged commit 8e07721 into embroider-build:master Jun 24, 2021
@chriskrycho
Copy link
Contributor

Not urgent, but checking in for the sake of unblocking usage of ember-element-helper@5: ETA on getting this into a 0.42.3 release?

@chriskrycho
Copy link
Contributor

chriskrycho commented Jun 28, 2021 •
edited
Loading

…literally 5 seconds after I posted this, v0.42.3 was released with the fix. @rwjblue!!! 😂

@thoov thoov mentioned this pull request Jun 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@embroider/macros is not parallelizable
3 participants
@thoov @rwjblue @chriskrycho