Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embroider:MacrosConfig] cannot read userConfigs until MacrosConfig has been finalized. #882

Open
thoov opened this issue Jun 29, 2021 · 2 comments
Assignees

Comments

@thoov
Copy link
Collaborator

thoov commented Jun 29, 2021

While upgrading ember-engines to use @embroider/macros v0.42.3 (#865) introduces [Embroider:MacrosConfig] cannot read userConfigs until MacrosConfig has been finalized.

@thoov
Copy link
Collaborator Author

thoov commented Jun 29, 2021

This issue was fixed by upgrading ember-cli-htmlbars from 5.3.1 to the latest 5.7.1. Specifically, ember-cli-htmlbars will need to have ember-cli/ember-cli-htmlbars#657 in order to work. This effectively means v5.3.2 or newer.

@thoov
Copy link
Collaborator Author

thoov commented Jun 29, 2021

We need to evaluate adding some kind of check to macros to make sure that this dependency is satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant