Avoid running CI jobs on both push and pull_request events. #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pushing changes to a branch, CI would run **double** the jobs (one set of CI jobs for the branch push event, and another set of jobs for the `pull_request` event). This change tweaks the CI hooks to only run for pull requests **targeting** `master` and branches named `master` (also allow `v*` style release branches, just in case we wanted them in the future).
|
👍 |
|
FWIW, this was intentional. They're supposed to be testing slightly different things. But I agree it's overkill. |
|
Hmmm. They run the same matrix as far as I could tell, how do they test different things? What was I missing? Happy to revert, and also change to primarily pushing to my own fork to avoid the double running. |
|
I was under the impression that git's default PR checking tests against a new commit that merges the PR with the target branch, whereas the branch checking tests exactly the PR's head commit. But I guess I was just assuming that and didn't see any docs. |
|
Either way, I'm still fine with this change. I pushed a copy of this repo into a branch on a private repo and the single run of actions that resulted ate my entire free quota. 😅 |
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing changes to a branch, CI would run double the jobs (one set of CI jobs for the branch push event, and another set of jobs for the
pull_requestevent).This change tweaks the CI hooks to only run for pull requests targeting
masterand branches namedmaster(also allowv*style release branches, just in case we wanted them in the future).Compare #703's (90 CI jobs) CI runs vs #694's (41 CI jobs).