Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run importSync transform later, so ember-auto-import can support importSync #694

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

simonihmig
Copy link
Collaborator

This runs the transform of importSync in the exit hook, to allow ember-auto-import to do its own transformation before us. See embroider-build/ember-auto-import#347

@simonihmig
Copy link
Collaborator Author

Unrelated canary failures here...

@simonihmig
Copy link
Collaborator Author

@ef4 can we merge this?

@rwjblue
Copy link
Collaborator

rwjblue commented Mar 2, 2021

@simonihmig the canary failures have been fixed, mind rebasing?

…rtSync

This runs the transform of importSync in the exit hook, to allow ember-auto-import to do its own transformation *before* us. See embroider-build/ember-auto-import#347
@simonihmig
Copy link
Collaborator Author

the canary failures have been fixed, mind rebasing?

Done, green now! Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants