Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new option for addon-shim to pass config to ember-auto-import #2158

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add a new option for addon-shim to pass config to ember-auto-import #2158

merged 2 commits into from
Oct 31, 2024

Commits on Oct 31, 2024

  1. Add a new option for addon-shim to pass config to ember-auto-import 

    This is part of the plan to ship ember-source as a v2 addon.

This piece makes it possible for a v2 addon to send additional configuration directly to the leading copy of ember-auto-import. This is different from how it worked before, which was that registerV2Addon calls all cascaded up the tree through intermediate copies of ember-auto-import, which might be any compatible minor version.

Instead, now if you add a specific version of ember-auto-import as a dependency of your v2 addon, you will be guaranteed to be talking to that version (or newer) when you registerV2Addon, and thus you can send new options and expect them to work.
    @ef4
    ef4 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e3e9bd8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/stable' into eai-compat-options

    @ef4
    ef4 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6827683 View commit details
    Browse the repository at this point in the history