Add a new option for addon-shim to pass config to ember-auto-import #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the plan to ship ember-source as a v2 addon. This piece makes it possible for a v2 addon to send additional configuration directly to the leading copy of ember-auto-import. This is different from how it worked before, which was that registerV2Addon calls all cascaded up the tree through intermediate copies of ember-auto-import, which might be any compatible minor version. Instead, now if you add a specific version of ember-auto-import as a dependency of your v2 addon, you will be guaranteed to be talking to that version (or newer) when you registerV2Addon, and thus you can send new options and expect them to work.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the plan to ship ember-source as a v2 addon.
This piece makes it possible for a v2 addon to send additional configuration directly to the leading copy of ember-auto-import. This is different from how it worked before, which was that registerV2Addon calls all cascaded up the tree through intermediate copies of ember-auto-import, which might be any compatible minor version.
Instead, now if you add a specific version of ember-auto-import as a dependency of your v2 addon, you will be guaranteed to be talking to that version (or newer) when you registerV2Addon, and thus you can send new options and expect them to work.