reorder extension precedence when searching app-js and fastboot-js trees #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Worth noting that this was previously said to be deliberate:
da744d9#diff-61967680c203e14cb9a3b2c252caca7d6b0ee9b285991dba6b728f6c54112a12L960-R1032
This order seems wrong, and tests pass, so 👍🏼 but if anyone somehow gets bitten by this, it may be worth tracing it deeper into why the original code had it done this way
|
The origin was #1463. It was definitely not intentional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this should always have been .js before .hbs and we just missed it when adding this.