fix resolution of files with .hbs extensions #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
void-mAlex
reviewed
Jun 12, 2023
ef4
commented
Jun 13, 2023
| @@ -306,7 +306,7 @@ export class Resolver { | |||
|
|
|||
| let pkg = this.owningPackage(match.filename); | |||
| if (pkg) { | |||
| let rel = withoutJSExt(explicitRelative(pkg.root, match.filename)); | |||
| let rel = explicitRelative(pkg.root, match.filename); | |||
There was a problem hiding this comment.
To drop withoutJSExt here you must replace it with the search over all resolvable extensions. That's what's causing the failure in the engine-relative resolving > file exists in both app-js and fastboot-js test.
I would suggest taking your implementation in searchAppTree and making it a utility method that you can use here too.
There was a problem hiding this comment.
Nice one, I completely missed that there was something else checking the mergemap 👍
mansona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @mansona, we have a bug here and need to make the app JS searching do a search for .js, .hbs, and .hbs.js resolvable extensions.