update pnpm #1649
Merged
update pnpm #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mansona
force-pushed
the
update-pnpm
branch
2 times, most recently
from
99df6c8
to
619ac4e
Compare
NullVoxPopuli
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating this PR because I saw something strange happening in #1594 with the types build. I didn't actually do anything that could have changed the types so I reasoned that the error must have happened because we were being hit by the problem with pnpm pre 8.7
The error with the type is:
I don't know what this means or why it's happening, it's a tough one to google 🙈 I pushed a fix that is probably not acceptable but at least I could get my types building locally. I would love for the TypeScript experts on the team to tell me what this
hackfix should really look like 😂Edit: Thanks to @NullVoxPopuli we fixed the type issues today and this PR is ready for review 🎉 the issue with babel types is opened as an "issue" here DefinitelyTyped/DefinitelyTyped#67183