-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove volta from CI #1594
remove volta from CI #1594
Conversation
80b4db2
to
2a67a7b
Compare
2a67a7b
to
9ba0a0e
Compare
seems like the one test that is failing is related directly to volta shenanigans ... we may need to see how that translates in a world without volta |
5ffa31e
to
ac6dfa0
Compare
ac6dfa0
to
90c0458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to remove Volta lets do it everywhere, in favor of using pnpm's built-in node version management via npmrc files.
The tests that need a specific node version should emit their own npmrc files, similar to how they emit their own Volta config now.
Volta maintainers discussing a fix: volta-cli/volta#1523 (comment) |
I'm submitting this PR for consideration again. I have implemented the pnpm node version management for the tests that need it but I have not implemented it across the board. My reasoning for this is that we specifically have tests that use I will add this PR to the meeting agenda for discussion 👍 |
488ac0b
to
416fc97
Compare
This PR attempts to just use the standard
actions/setup-node
infra to setup node because the volta infra keeps crashing on us