Move @embroider/macros from emberVirtualPackages to emberVirtualPeerDeps #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that `@embroider/macros/runtime` was getting force-externalized in an app. Which would make sense if it were really an emberVirtualPackage, but it's a real package so it should be listed in emberVirtualPeerDeps instead. (It's true that most of what it exposes is "virtual" in the sense of having babel implementation, but the package does provide some runtime implementation too and that should be resolved to the real package)
|
(This only started to matter due to the recent #1495) |
void-mAlex
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
@embroider/macros/runtimewas getting force-externalized in an app. Which would make sense if it were really an emberVirtualPackage, but it's a real package so it should be listed in emberVirtualPeerDeps instead.(It's true that most of what it exposes is "virtual" in the sense of having babel implementation, but the package does provide some runtime implementation too and that should be resolved to the real package)