Eagerly virtualize emberVirtualPackages #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and expand the list of virtual pacakges to includes some that are private-but-used-API. Before this, we only provided these as fallbacks when normal resolving failed, and this mostly worked. But that was when we were also rewriting the entire node_modules graph on disk. Now that we don't do that, there are many more opportunities to accidentally resolve copies of packages that aren't really what you expected.
| @@ -37,6 +37,11 @@ emberVirtualPackages.add('@embroider/macros'); | |||
| // the modules-api-polyfill. Newer APIs need to be added here. | |||
| emberVirtualPackages.add('@ember/owner'); | |||
|
|
|||
| // these are not public API but they're included in ember-source, so for | |||
| // correctness we still want to understand that they come from there. | |||
| emberVirtualPackages.add('@glimmer/validator'); | |||
There was a problem hiding this comment.
should all the glimmer packages from ember-source be listed here?
@glimmer/compiler@glimmer/syntax- etc?
or is it best to only add if someone brings it up? 😅
There was a problem hiding this comment.
It would be good to be complete. Also it would be good to make these lists ember-version-dependent.
NullVoxPopuli
approved these changes
Jun 30, 2023
...and bumping tsconfig target because I wanted to use replaceAll and it definitely works in our supported node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and expand the list of virtual pacakges to includes some that are private-but-used-API.
Before this, we only provided these as fallbacks when normal resolving failed, and this mostly worked. But that was when we were also rewriting the entire node_modules graph on disk. Now that we don't do that, there are many more opportunities to accidentally resolve copies of packages that aren't really what you expected.