Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not write package.json when there are no changes (affects addon.appReexports() and addon.publicAssets()) #1423

Merged
merged 8 commits into from
May 30, 2023
Merged

Do not write package.json when there are no changes (affects addon.appReexports() and addon.publicAssets()) #1423

merged 8 commits into from
May 30, 2023

Commits on May 18, 2023

  1. Resolve embroider-build#1420

    @NullVoxPopuli
    NullVoxPopuli committed May 18, 2023
    Configuration menu
    Copy the full SHA
    cc6ecd2 View commit details
    Browse the repository at this point in the history

  2. Use consistent returns and add explicit return type

    @NullVoxPopuli
    NullVoxPopuli committed May 18, 2023
    Configuration menu
    Copy the full SHA
    921fc44 View commit details
    Browse the repository at this point in the history

  3. Move new functions to their own file

    @NullVoxPopuli
    NullVoxPopuli committed May 18, 2023
    Configuration menu
    Copy the full SHA
    571be71 View commit details
    Browse the repository at this point in the history

  4. Public assets needed the same condition

    @NullVoxPopuli
    NullVoxPopuli committed May 18, 2023
    Configuration menu
    Copy the full SHA
    6de3528 View commit details
    Browse the repository at this point in the history

  5. Simplify hasChanges logic via JSON.stringify

    @NullVoxPopuli
    NullVoxPopuli committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c41af5f View commit details
    Browse the repository at this point in the history

  6. Fix variable name

    @NullVoxPopuli
    NullVoxPopuli committed May 18, 2023
    Configuration menu
    Copy the full SHA
    7d18d20 View commit details
    Browse the repository at this point in the history

  7. Add a test for testing the watch mode behavior and expectations of our 

    rollup plugins
    @NullVoxPopuli
    NullVoxPopuli committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1ef57d6 View commit details
    Browse the repository at this point in the history

  8. Move non-watching test outside the watching Q-module

    @NullVoxPopuli
    NullVoxPopuli committed May 18, 2023
    Configuration menu
    Copy the full SHA
    26a768f View commit details
    Browse the repository at this point in the history