-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollup-app-reexports writes package.json even if not needed #1420
Comments
NullVoxPopuli
added a commit
to NullVoxPopuli/embroider
that referenced
this issue
May 12, 2023
NullVoxPopuli
added a commit
to NullVoxPopuli/embroider
that referenced
this issue
May 15, 2023
NullVoxPopuli
added a commit
to NullVoxPopuli/embroider
that referenced
this issue
May 17, 2023
NullVoxPopuli
added a commit
to NullVoxPopuli/embroider
that referenced
this issue
May 18, 2023
NullVoxPopuli
added a commit
to NullVoxPopuli/embroider
that referenced
this issue
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use perforce as a source control system. All files which you are not modifying are read-only.
So the build fails because
rollup-app-reexports
writes the filepackage.json
even if the result is the same as the original content (https://github.com/embroider-build/embroider/blob/1ecd57ea20195cd54358debde5801f82611d81d1/packages/addon-dev/src/rollup-app-reexports.ts#LL38C19-L38C19)So, it would be nice if
rollup-app-reexports
would only write a source file if neededThe text was updated successfully, but these errors were encountered: