Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test suite compat #1152

Merged
merged 2 commits into from
Mar 7, 2022
Merged

improve test suite compat #1152

merged 2 commits into from
Mar 7, 2022

Commits on Mar 7, 2022

  1. improve test suite compat 

    There's no reason not to provide every module under /tests to the runtime loader. This is closer to how classic builds work and doesn't have a downside.

In an earlier version, we used to need to identify which files were actually tests because we would eagerly evaluate them all (and skip the traditional ember test loader), but that was already scrapped in favor of easier compatibility for test suites, so I don't think this has a downside.

The motivating use case for this was ember-data-factory-guy, which does runtime lookup of modules in `tests/factories` that don't match the `-test.js` naming convention.
    @ef4
    ef4 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    40df760 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into improve-tests-compat

    @ef4
    ef4 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    6970bed View commit details
    Browse the repository at this point in the history