Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test suite compat #1152

Merged
merged 2 commits into from
Mar 7, 2022
Merged

improve test suite compat #1152

merged 2 commits into from
Mar 7, 2022

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Mar 7, 2022

There's no reason not to provide every module under /tests to the runtime loader. This is closer to how classic builds work and doesn't have a downside.

In an earlier version, we used to need to identify which files were actually tests because we would eagerly evaluate them all (and skip the traditional ember test loader), but that was already scrapped in favor of easier compatibility for test suites, so I don't think this has a downside.

The motivating use case for this was ember-data-factory-guy, which does runtime lookup of modules in tests/factories that don't match the -test.js naming convention.

ef4 added 2 commits March 7, 2022 00:57
There's no reason not to provide every module under /tests to the runtime loader. This is closer to how classic builds work and doesn't have a downside.

In an earlier version, we used to need to identify which files were actually tests because we would eagerly evaluate them all (and skip the traditional ember test loader), but that was already scrapped in favor of easier compatibility for test suites, so I don't think this has a downside.

The motivating use case for this was ember-data-factory-guy, which does runtime lookup of modules in `tests/factories` that don't match the `-test.js` naming convention.
@ef4 ef4 added the bug Something isn't working label Mar 7, 2022
@ef4 ef4 merged commit 61aeeeb into main Mar 7, 2022
@ef4 ef4 deleted the improve-tests-compat branch March 7, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant