use the latest pnpm/action-setup and don't define pnpm version if packageManager is defined #127
Conversation
mansona
force-pushed
the
use-latest-pnpm-action
branch
from
6db6f57
to
7ed32cc
Compare
| <% if (pnpm) { %> | ||
| - uses: pnpm/action-setup@v3 | ||
| node-version: 18<% if (pnpm) { %> | ||
| - uses: pnpm/action-setup@v4<% if (!hasPackageManager) { %> | ||
| with: |
There was a problem hiding this comment.
why specify the version at all? the duplication in workflows is maddening.
This is what package.json#packageManager is for
There was a problem hiding this comment.
or wait, I can't read ejs.
this does exactly what I expect.
There was a problem hiding this comment.
look a bit more carefully at the change, it only adds the version if you haven't set packageManager. And version is a required parameter if you haven't got packageManager so the action will break without it
I agree that packageManager should be used by most people at this stage but we can't impose it as part of our workflow. And people who do define it will benefit from it 💪
There was a problem hiding this comment.
I think we crossed paths
There was a problem hiding this comment.
omg Github 😭 this is why eventual consistency doesn't always work. it didn't even update the thread after I posted my response
No description provided.