Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflows do not derive the pnpm / node versions from the repo/envirnoment/config files. #111

Closed
NullVoxPopuli opened this issue May 6, 2024 · 1 comment
Closed

Workflows do not derive the pnpm / node versions from the repo/envirnoment/config files. #111

NullVoxPopuli opened this issue May 6, 2024 · 1 comment

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented May 6, 2024 •
edited
Loading

hard-coding version 8 has broken everyone to upgrading to version 9.

For now, I've been replacing this with a GH action that does all this for me:

- uses: wyvox/action-setup-pnpm@v3

it's been much less brittle because it reads all the places pnpm version can be set

Been doing this on a few PRs:

image
NullVoxPopuli added a commit to adopted-ember-addons/ember-moment that referenced this issue Jun 25, 2024
@NullVoxPopuli
Fix release-plan workflows due to embroider-build/create-release-plan…
8cb7ed2 
…-setup#111
@chuckcarpenter chuckcarpenter mentioned this issue Jun 26, 2024
Merged
@NullVoxPopuli NullVoxPopuli mentioned this issue Jul 2, 2024
Merged
@mansona
Copy link
Member

mansona commented Jul 17, 2024

This has been fixed in #127

If you provide a packageManager we will use it 🎉

@mansona mansona closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NullVoxPopuli @mansona