Skip to content

docs: add todo for licenses patch#1415

Merged
overbalance merged 1 commit into
mainfrom
overbalance/add-todo-for-patch
Jul 7, 2026
Merged

docs: add todo for licenses patch#1415
overbalance merged 1 commit into
mainfrom
overbalance/add-todo-for-patch

Conversation

@overbalance

Copy link
Copy Markdown
Member

What problem is this solving?

The generate-license-file+4.2.1.patch sorts discovered license files for deterministic cross-platform notices, but it's a local patch waiting on an upstream fix. Without a marker, it's easy to forget to drop the patch once upstream lands the change.

Short description of the changes

Adds a # TODO comment at the top of the patch pointing at the upstream PR (TobyAndToby/generate-license-file#743) so the patch can be removed once that PR is merged and released.

How was this tested?

Docs/comment-only change to a patch header; no behavior change. The patch still applies cleanly.

Checklist

  • Change is documentation only
  • No functional/runtime impact

@overbalance
overbalance requested a review from a team as a code owner July 7, 2026 20:57
@overbalance
overbalance enabled auto-merge (squash) July 7, 2026 20:59
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
Chrome DevTools Protocol Tracing (Script: 124.93ms, Heap: 13.53MB)
Number of Requests Size of Requests Script Duration Task Duration Heap Used Size
Requests +13 requests +41.81 KB
Page Loaded +24.00 ms -5.59 ms +1.17 MB
Generate 100 fetch requests +24.42 ms +91.01 ms +1.70 MB
Generate 100 XHR requests +44.31 ms +122.39 ms +2.79 MB
Click 100 buttons and generate 100 logs +21.98 ms +52.36 ms +2.31 MB
Throw a 100 exceptions +0.11 ms +33.05 ms +2.31 MB
End Session +10.10 ms +19.99 ms +3.26 MB
Total +13 requests +41.81 KB +124.93 ms +313.21 ms +13.53 MB
Lighthouse (Script Eval: 138.82ms)
Difference Description
Total Blocking Time +5 ms Difference in Total Blocking Time: Sum of all time periods between FCP and Time to Interactive, when task length exceeded 50ms, expressed in milliseconds. Learn more about the Total Blocking Time metric.
Main Thread Time +124.47 ms Difference in Main Thread Time: Consider reducing the time spent parsing, compiling and executing JS. You may find delivering smaller JS payloads helps with this. Learn how to minimize main-thread work
Script Evaluation Time +138.82 ms Difference in Script Evaluation Time: Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. Learn how to reduce Javascript execution time.
Platform Tests (vite-7 es2015 gzip: 69.66KB)

vite-6 Platform Tests

Total Uncompressed Size Total Gzip Size
vite-6 - es2015 +203.00 KB +69.70 KB

vite-7 Platform Tests

Total Uncompressed Size Total Gzip Size
vite-7 - es2015 +203.00 KB +69.66 KB

webpack-5 Platform Tests

Total Uncompressed Size Total Gzip Size
webpack-5 - es2015 0 KB 0 KB

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (1cb7e8d) to head (3f40fcd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1415      +/-   ##
==========================================
+ Coverage   96.67%   96.68%   +0.01%     
==========================================
  Files         234      234              
  Lines        9918     9918              
  Branches     1381     1382       +1     
==========================================
+ Hits         9588     9589       +1     
+ Misses        328      327       -1     
  Partials        2        2              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@overbalance
overbalance merged commit 2a37a7d into main Jul 7, 2026
20 checks passed
@overbalance
overbalance deleted the overbalance/add-todo-for-patch branch July 7, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants