docs: add todo for licenses patch#1415
Merged
Merged
Conversation
Contributor
Chrome DevTools Protocol Tracing (Script: 124.93ms, Heap: 13.53MB)
Lighthouse (Script Eval: 138.82ms)
Platform Tests (vite-7 es2015 gzip: 69.66KB)vite-6 Platform Tests
vite-7 Platform Tests
webpack-5 Platform Tests
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
+ Coverage 96.67% 96.68% +0.01%
==========================================
Files 234 234
Lines 9918 9918
Branches 1381 1382 +1
==========================================
+ Hits 9588 9589 +1
+ Misses 328 327 -1
Partials 2 2 🚀 New features to boost your workflow:
|
jpmunz
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
The
generate-license-file+4.2.1.patchsorts discovered license files for deterministic cross-platform notices, but it's a local patch waiting on an upstream fix. Without a marker, it's easy to forget to drop the patch once upstream lands the change.Short description of the changes
Adds a
# TODOcomment at the top of the patch pointing at the upstream PR (TobyAndToby/generate-license-file#743) so the patch can be removed once that PR is merged and released.How was this tested?
Docs/comment-only change to a patch header; no behavior change. The patch still applies cleanly.
Checklist