fix: sort discovered license files for deterministic cross-platform output#743
Open
overbalance wants to merge 1 commit into
Open
fix: sort discovered license files for deterministic cross-platform output#743overbalance wants to merge 1 commit into
overbalance wants to merge 1 commit into
Conversation
overbalance
force-pushed
the
overbalance/case-sensitivity
branch
from
July 7, 2026 17:36
a53c25a to
fd5bcbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
licenseFilepicksfilteredLicenseFiles[0]fromglob(...), whose match order is filesystem-dependent. With{ nocase: true }the casing differs too: macOS yieldslicense, Linux yieldsLICENSE. So a dependency shipping multiple matches (e.g.import-in-the-middleships bothLICENSEandLICENSE-3rdparty.csv) can resolve to different license text on macOS vs Linux CI, breaking committed-notices drift checks.Fix
Sort the matches case-insensitively (locale-independently) before picking. A plain
.sort()isn't enough:LICENSE-3rdparty.csvsorts ahead of lowercaselicense, so macOS would pick the CSV. Lowercasing first puts the baselicenseahead of variants likelicense-3rdparty.csvon both platforms.Test
Simulates both filesystems (glob returning
LICENSEand lowercaselicense, each alongsideLICENSE-3rdparty.csv) and asserts both resolve to the real license.