Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

3.6 blog post #3673

Merged
merged 29 commits into from
Dec 13, 2018
Merged

3.6 blog post #3673

merged 29 commits into from
Dec 13, 2018

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented Nov 7, 2018 •
edited
Loading

What it does

Adds the 3.6 release information to the release blog post.

Checklist

  • framework
  • ember-cli
  • ember-data

Related Issue(s)

@locks locks temporarily deployed to ember-website-staging-pr-3673 November 7, 2018 15:24 Inactive
@kennethlarsen
Copy link
Member

kennethlarsen commented Nov 7, 2018 •
edited
Loading

Ember.js

Ember Data

  • No new features

Ember-CLI
Changelog: https://github.com/ember-cli/ember-cli/blob/v3.6.0-beta.1/CHANGELOG.md
Most relevant:

@locks locks temporarily deployed to ember-website-staging-pr-3673 November 8, 2018 09:05 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 8, 2018 09:14 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 8, 2018 09:34 Inactive
@acorncom acorncom temporarily deployed to ember-website-staging-pr-3673 November 9, 2018 06:42 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 13, 2018 07:17 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 13, 2018 07:23 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 13, 2018 07:24 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 17, 2018 11:39 Inactive
@kennethlarsen kennethlarsen changed the title [WIP] 3.6 blog post 3.6 blog post Nov 17, 2018
@kennethlarsen kennethlarsen changed the title 3.6 blog post [Don't merge until release] 3.6 blog post Nov 17, 2018
jenweber
jenweber previously requested changes Nov 17, 2018
View reviewed changes
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small edits and additions. The most important is the TC39 comment, since someone who doesn’t know what that is would think that it’s Ember’s fault that we aren’t using the latest and greatest, rather than us being responsible and thoughtful.

source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 17, 2018 21:08 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 17, 2018 21:12 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 18, 2018 08:15 Inactive
@jenweber jenweber mentioned this pull request Nov 18, 2018
Closed
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 21, 2018 07:28 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 21, 2018 11:10 Inactive
jayjayjpg
jayjayjpg reviewed Nov 26, 2018
View reviewed changes
Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great ✨ I just left a few more suggestions for minor spelling fixes

source/blog/2018-11-19-ember-3-6-released.md Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
source/blog/2018-11-19-ember-3-6-released.md Outdated Show resolved Hide resolved
@locks locks temporarily deployed to ember-website-staging-pr-3673 November 30, 2018 04:15 Inactive
@kennethlarsen kennethlarsen changed the title [Don't merge until release] 3.6 blog post 3.6 blog post Dec 7, 2018
@locks locks dismissed jenweber’s stale review December 13, 2018 10:07

Points addressed

@locks locks merged commit 7ace5d9 into master Dec 13, 2018
@locks locks deleted the feature/3-6-blog branch December 13, 2018 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rwjblue rwjblue rwjblue left review comments

@Turbo87 Turbo87 Turbo87 left review comments

@Gaurav0 Gaurav0 Gaurav0 left review comments

@pzuraq pzuraq pzuraq left review comments

@kennethlarsen kennethlarsen kennethlarsen left review comments

@jayjayjpg jayjayjpg jayjayjpg left review comments

@tsing80 tsing80 tsing80 left review comments

@jenweber jenweber jenweber left review comments

@locks locks locks approved these changes

Assignees

@kennethlarsen kennethlarsen

@MelSumner MelSumner

Labels
content 📝 ready-for-review ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.