[core-object] Delay init until after construction #16795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
feat/delay-init-until-after-construction
branch
2 times, most recently
from
8abd40d
to
cb408aa
Compare
pzuraq
force-pushed
the
feat/delay-init-until-after-construction
branch
from
cb408aa
to
e530f3d
Compare
Implements RFC 337, delaying initialization of create properties until after object construction.
pzuraq
force-pushed
the
feat/delay-init-until-after-construction
branch
from
e530f3d
to
9a817d4
Compare
pzuraq
changed the title
krisselden
approved these changes
Sep 24, 2018
rwjblue
approved these changes
Sep 26, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements RFC 337, delaying initialization of create properties until after object construction. This PR is currently meant to be a PoC, and is dependent on the RFC being merged. It'll also help to inform certain behaviors, like for instance whether or not we should deprecate
new EmberObject()altogether, or just deprecate passing in init properties.There are two commits on this branch currently, one in which chains are enabled during the initial construction phase, then disabled when the init properties are applied, and one where they are disabled throughout construction. Both have been benchmarked against master, which shows a minor regression in terms of speed.
results.pdf
results.json.txt