Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array helper #318

Merged
merged 1 commit into from
Apr 6, 2018
Merged

array helper #318

merged 1 commit into from
Apr 6, 2018

Conversation

mmun
Copy link
Member

@mmun mmun commented Mar 24, 2018 •
edited by locks
Loading

Rendered

Closes #128.

@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2018

:shipit: ❗️ ❤️

@kellyselden
Copy link
Member

Closes #128

Also prior art https://github.com/kellyselden/ember-array-helper

@mmun
Copy link
Member Author

mmun commented Mar 24, 2018

@kellyselden Damn! I should have checked first, sorry!

@kellyselden
Copy link
Member

No worries. One less addon to maintain!

@ryanto
Copy link

ryanto commented Mar 25, 2018

Awesome, it would replace https://github.com/DockYard/ember-composable-helpers#array which we use in a lot of our apps.

@lukemelia
Copy link
Member

Yes, please! It's unpleasantly surprising that Ember ships with a hash helper and not an array helper.

@tim-evans
Copy link

I've previously called the ones I've written list. Just an alternative name 😉

@mmun
Copy link
Member Author

mmun commented Mar 30, 2018

We discussed this at the core team meeting on 2018-03-30 and are ready to mark it for final comment period.

@Serabe
Copy link
Member

Serabe commented Mar 31, 2018

@mmun after Glimmer 2 I had to change https://github.com/Serabe/ember-pirate implementation to copy the array, since the params is a frozen object. Done so by users request, so it might be nice to add it to the RFC.

@rwjblue rwjblue merged commit 0f4014d into master Apr 6, 2018
@rwjblue rwjblue deleted the array-helper branch April 6, 2018 18:17
@rwjblue rwjblue mentioned this pull request Oct 7, 2018
Closed
5 tasks
@josemarluedke josemarluedke mentioned this pull request Oct 8, 2018
Merged
@kategengler kategengler mentioned this pull request Feb 12, 2019
Closed
3 tasks
alexdiliberto pushed a commit to alexdiliberto/ember-transformicons that referenced this pull request Mar 6, 2019
@dependabot @alexdiliberto
build(deps-dev): bump ember-source from 3.7.3 to 3.8.0 (#207)
d0918f8 
Bumps [ember-source](https://github.com/emberjs/ember.js) from 3.7.3 to 3.8.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-source's releases](https://github.com/emberjs/ember.js/releases).*

> ## v3.8.0
> ### CHANGELOG
> 
> - [#17143](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17143) / [#17375](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17375) [FEATURE] Implement Element Modifier Manager RFC (see [emberjs/rfcs#373](https://github.com/emberjs/rfcs/blob/master/text/0373-Element-Modifier-Managers.md)).
> - [#17054](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17054) / [#17376](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17376) [FEATURE] Implement `array` helper RFC (see [emberjs/rfcs#318](https://github.com/emberjs/rfcs/blob/master/text/0318-array-helper.md))
> - [#16735](https://github-redirect.dependabot.com/emberjs/ember.js/pull/16735) [BUGFIX] Observed properties not being marked as enum
> - [#17498](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17498) [BUGFIX] Don't remove dep keys in `didUnwatch`
> - [#17467](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17467) [BUGFIX] Fix substate interactions with aborts
> - [#17413](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17413) [BUGFIX] Fix missing import in instance-initializer blueprint for ember-mocha
> - [#17319](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17319) [CLEANUP] Remove deprecated 'POSITIONAL_PARAM_CONFLICT'
> - [#17394](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17394) [CLEANUP] Remove deprecated code in mixins/array
> - [#17244](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17244) / [#17499](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17499) Upgrade to Glimmer VM 0.37.1
> Fixes a few issues:
>   * Usage of positional arguments with custom components.
>   * Forwarding attributes via `...attributes` to a dynamic component.
>   * Prevent errors when rendering many template blocks (`Error: Operand over 16-bits. Got 65536`).
> - [#17166](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17166) Improve performance of get() / set()
> - [#16710](https://github-redirect.dependabot.com/emberjs/ember.js/pull/16710) Deprecation of private `NAME_KEY`
> - [#17216](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17216) Use native Error instead of custom Error subclass.
> - [#17340](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17340) Remove unused `hooks` variable from qunit-rfc-232 util-test blueprint
> - [#17357](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17357) Allow notifyPropertyChange to be imported from @ember/object
> 
> 
> ## v3.8.0-beta.5
> ### CHANGELOG
> 
> - [#17563](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17563) [BUGFIX] Transition.send/trigger call signature
> 
> ## v3.8.0-beta.4
> ### CHANGELOG
> 
> - [#17552](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17552) [BUGFIX] Support numbers in component names for Angle Brackets
> 
> ## v3.8.0-beta.3
> ### CHANGELOG
> 
> - [#17498](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17498) [BUGFIX] Don't remove dep keys in `didUnwatch`
> - [#17499](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17499) [BUGFIX] Update to glimmer-vm 0.37.1.
> 
> ## v3.8.0-beta.2
> ### CHANGELOG
> 
> - [#17467](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17467) [BUGFIX] Fix substate interactions with aborts
> 
> ## v3.8.0-beta.1
> ### CHANGELOG
> 
> - [#17143](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17143) / [#17375](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17375) [FEATURE] Implement Element Modifier Manager RFC (see [emberjs/rfcs#373](https://github.com/emberjs/rfcs/blob/master/text/0373-Element-Modifier-Managers.md)).
> - [#17054](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17054) / [#17376](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17376) [FEATURE] Implement `array` helper RFC (see [emberjs/rfcs#318](https://github.com/emberjs/rfcs/blob/master/text/0318-array-helper.md))
> - [#16735](https://github-redirect.dependabot.com/emberjs/ember.js/pull/16735) [BUGFIX] Observed properties not being marked as enum
></tr></table> ... (truncated)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [ember-source's changelog](https://github.com/emberjs/ember.js/blob/master/CHANGELOG.md).*

> ### v3.8.0 (February 18, 2019)
> 
> - [#17143](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17143) / [#17375](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17375) [FEATURE] Implement Element Modifier Manager RFC (see [emberjs/rfcs#373](https://github.com/emberjs/rfcs/blob/master/text/0373-Element-Modifier-Managers.md)).
> - [#17054](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17054) / [#17376](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17376) [FEATURE] Implement `array` helper RFC (see [emberjs/rfcs#318](https://github.com/emberjs/rfcs/blob/master/text/0318-array-helper.md))
> - [#16735](https://github-redirect.dependabot.com/emberjs/ember.js/pull/16735) [BUGFIX] Observed properties not being marked as enum
> - [#17498](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17498) [BUGFIX] Don't remove dep keys in `didUnwatch`
> - [#17467](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17467) [BUGFIX] Fix substate interactions with aborts
> - [#17413](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17413) [BUGFIX] Fix missing import in instance-initializer blueprint for ember-mocha
> - [#17319](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17319) [CLEANUP] Remove deprecated 'POSITIONAL_PARAM_CONFLICT'
> - [#17394](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17394) [CLEANUP] Remove deprecated code in mixins/array
> - [#17244](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17244) / [#17499](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17499) Upgrade to Glimmer VM 0.37.1
> Fixes a few issues:
>   * Usage of positional arguments with custom components.
>   * Forwarding attributes via `...attributes` to a dynamic component.
>   * Prevent errors when rendering many template blocks (`Error: Operand over 16-bits. Got 65536`).
> - [#17166](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17166) Improve performance of get() / set()
> - [#16710](https://github-redirect.dependabot.com/emberjs/ember.js/pull/16710) Deprecation of private `NAME_KEY`
> - [#17216](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17216) Use native Error instead of custom Error subclass.
> - [#17340](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17340) Remove unused `hooks` variable from qunit-rfc-232 util-test blueprint
> - [#17357](https://github-redirect.dependabot.com/emberjs/ember.js/pull/17357) Allow notifyPropertyChange to be imported from @ember/object
</details>
<details>
<summary>Commits</summary>

- [`3013779`](emberjs/ember.js@3013779) Release v3.8.0
- [`43e8cb6`](emberjs/ember.js@43e8cb6) Add v3.8.0 to CHANGELOG
- [`899be80`](emberjs/ember.js@899be80) Release v3.8.0-beta.5
- [`39bb0d4`](emberjs/ember.js@39bb0d4) Add v3.8.0-beta.5 to CHANGELOG
- [`494d83d`](emberjs/ember.js@494d83d) [DOC beta] Add deprecation tag for Ember.merge
- [`472673d`](emberjs/ember.js@472673d) [DOC lts] Addressed PR comments by rwjblue
- [`8a42b3b`](emberjs/ember.js@8a42b3b) [DOC lts] Addressed PR comments
- [`71c2fe5`](emberjs/ember.js@71c2fe5) [DOC] Angle Bracket invocation
- [`4a67315`](emberjs/ember.js@4a67315) Add v3.7.3 to CHANGELOG
- [`3db1a75`](emberjs/ember.js@3db1a75) Bump router_js from 6.2.2 to 6.2.3
- Additional commits viewable in [compare view](emberjs/ember.js@v3.7.3...v3.8.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-source&package-manager=npm_and_yarn&previous-version=3.7.3&new-version=3.8.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-source&package-manager=npm_and_yarn&previous-version=3.7.3&new-version=3.8.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
@chrisrng chrisrng mentioned this pull request Mar 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mmun mmun

Labels
Final Comment Period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add {{array ...}} helper
7 participants
@mmun @rwjblue @kellyselden @ryanto @lukemelia @tim-evans @Serabe