Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement + enable array Helper Feature #17052

Closed
4 of 5 tasks
rwjblue opened this issue Oct 7, 2018 · 14 comments
Closed
4 of 5 tasks

Implement + enable array Helper Feature #17052

rwjblue opened this issue Oct 7, 2018 · 14 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Oct 7, 2018

This is a tracking issue to enable the array helper as proposed in emberjs/rfcs#318.

  • Implement
  • API Docs
  • Guides
  • Enable by default
  • Author a polyfill (e.g. ember-array-helper-polyfill)?
@josemarluedke
Copy link
Sponsor Contributor

🔒 I will give this implementation a try.

@rwjblue
Copy link
Member Author

rwjblue commented Oct 7, 2018

Some general implementation notes, I believe this should roughly be implemented the same way as the hash helper (but using positional args instead of named args).

@kanongil
Copy link
Contributor

kanongil commented Oct 7, 2018

I really think you need to revisit the an entirely new array is returned on changes thing on this (and the hash helper). The ember component system is not geared for this, as any change to any property, or sub-property, of any element triggers a re-validation of the whole array.

@rwjblue
Copy link
Member Author

rwjblue commented Oct 8, 2018

@kanongil - I'm not sure that I agree, the point is that revalidating the full array is not expensive.

@kanongil
Copy link
Contributor

kanongil commented Oct 8, 2018

That is not my experience from the hash helper. I can’t see why this would be different.

@rwjblue rwjblue reopened this Oct 13, 2018
@rwjblue
Copy link
Member Author

rwjblue commented Oct 13, 2018

Added a few more todo items:

  • Guides
  • Enable by default

@rwjblue
Copy link
Member Author

rwjblue commented Oct 13, 2018

@josemarluedke - Interested in picking up the guides work also?

@YoranBrondsema
Copy link
Contributor

@rwjblue Saw this issue and don't think that @josemarluedke had picked up the guide yet. So wrote a short blurb in the guide in ember-learn/guides-source#209.

@rwjblue
Copy link
Member Author

rwjblue commented Oct 14, 2018

Nice, thank you!

@SergeAstapov
Copy link
Contributor

@rwjblue
Copy link
Member Author

rwjblue commented Nov 21, 2018

@SergeAstapov - It certainly could be, but it would need some changes. Specifically, it would need to be updated to do nothing when it detects the newer Ember version that ships the helper by default.

@kategengler
Copy link
Member

@kellyselden Any interest in updating your ember-array-helper addon (mentioned above) to be a polyfill?

@kellyselden
Copy link
Member

Of course. I can donate it or just add people, whatever need be.

@locks
Copy link
Contributor

locks commented May 30, 2019

This is le done.

@locks locks closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants