Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Types: resolve services with Owner.lookup #20319

Merged
merged 1 commit into from
Dec 9, 2022
Merged

[BUGFIX beta] Types: resolve services with Owner.lookup #20319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/@ember/service/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,16 @@ export function service(
export default class Service extends FrameworkObject {
static isServiceFactory = true;
}

/**
A type registry for Ember `Service`s. Meant to be declaration-merged so string
lookups resolve to the correct type.
*/
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface Registry extends Record<string, Service> {}

declare module '@ember/owner' {
export interface DIRegistry {
service: Registry;
}
}