Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Types: resolve services with Owner.lookup #20319

Merged
merged 1 commit into from
Dec 9, 2022

Commits on Dec 9, 2022

  1. Types: resolve services with Owner.lookup

    Integrate the service registry into the `DIRegistry` introduced as part
    of rationalizing the `Owner` types in PR #20271 (94276b5). This allows
    `Owner.lookup('service:foo')` to resolve a `FooService` if one is set
    up in the `@ember/service` module's `Registry` interface. The preview
    types already used this mechanic (as of 5658b13), so this just means
    that when we ship the stable (i.e. built from source) version of
    `@ember/service`, it will *continue* working.
    
    Meta: Shipping this implementation for the lookup was blocked on being
    able to publish type modules with `declare module`, which was
    implemented in PR #20316 (9adcd15). We will likely need to rework other
    parts of the type hierarchy to support publishing from source.
    chriskrycho committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5070508 View commit details
    Browse the repository at this point in the history